Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue when converting blockquotes with child text nodes #36

Merged
merged 4 commits into from
Feb 18, 2025
Merged

Fixed issue when converting blockquotes with child text nodes #36

merged 4 commits into from
Feb 18, 2025

Conversation

srtfisher
Copy link
Member

@srtfisher srtfisher commented Feb 18, 2025 •
edited
Loading

Fixes #33

@srtfisher srtfisher mentioned this pull request Feb 18, 2025
Closed
vancoder
vancoder approved these changes Feb 18, 2025
View reviewed changes
Copy link

@vancoder vancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌴

@srtfisher srtfisher merged commit f49d27d into develop Feb 18, 2025
5 checks passed
@srtfisher srtfisher deleted the hotfix/text-call branch February 18, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vancoder vancoder vancoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

convert_with_children needs to call $this->convert_node instead of $this->{$child->nodeName}
2 participants
@srtfisher @vancoder